buzz-acp: add structured MCP server configuration - #4164
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f9e32d5848
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
#4301 now describes the broader portable-agent lifecycle using Buzz's existing agent, template, connection, version and snapshot concepts. This PR remains the first narrow slice: structured, named MCP configuration in |
9cc1104 to
8c99312
Compare
8c99312 to
85ef19f
Compare
85ef19f to
dbf1cc4
Compare
|
@tlongwell-block @wpfleger96, @custard-pirate and I agree on the MCP split: #4164 owns the versioned document and stdio transport; #4271 adds HTTP to that schema. #4480 can then use the same document for live changes instead of adding a third config format. That leaves Buzz with one MCP configuration surface and one compatibility input. Could one of you confirm this ownership split? If so, I will keep #4164 at that boundary and help adapt #4271 to it. |
d0d3236 to
780561c
Compare
|
@tlongwell-block @wpfleger96, I have replaced the repair history with four reviewable commits on current Local tests, Clippy, formatting and the real two-server, two-session proof are green. CI is running. |
Signed-off-by: KC <79471844+wolfyy970@users.noreply.github.com>
Signed-off-by: KC <79471844+wolfyy970@users.noreply.github.com>
Signed-off-by: KC <79471844+wolfyy970@users.noreply.github.com>
Signed-off-by: KC <79471844+wolfyy970@users.noreply.github.com>
780561c to
0945861
Compare
1 participant
Summary
This gives Buzz one versioned MCP launch document instead of one opaque command per agent.
buzz-acpaccepts multiple named stdio servers, preserves their order, arguments and environment, and sends the same list through every ACP session. The existingBUZZ_ACP_MCP_COMMANDpath remains the first compatibility input.#4271 can add HTTP to the same document. Desktop and Project Connections can resolve approved tools into it without adding another runtime format.
Boundary
This document is resolved launch input. Personas, templates and Projects remain authoring state and are not passed directly to a runtime.
The adapter still inherits the harness environment, so this is explicit configuration rather than process isolation. On Unix, config files must be absolute, regular, owner-owned and owner-only. MCP values are structurally redacted from logs, observer events, diagnostics and returned adapter errors without changing the values sent to the agent.
Validation
cargo test -p buzz-core -p buzz-acp -p buzz-agent --no-fail-fastcargo clippy -p buzz-core -p buzz-acp -p buzz-agent --all-targets -- -D warningscargo fmt --all -- --checkFixes #4154.